tsdoc icon indicating copy to clipboard operation
tsdoc copied to clipboard

Upgrade Node.js and `node-sass` dependencies

Open kraenhansen opened this issue 1 year ago β€’ 1 comments

I tried following the instructions on Building the projects, but noticed two blockers:

  • The rush.json declares Node.js v14 as the highest supported version for the repo, while it has now dropped out of maintenance. It could probably easily be expanded to include v18 (the currently active LTS version).
  • tsdoc-playground declares a dependency on node-sass in version 4.14.1, which was published 3+ years ago and therefore doesn't have native prebuilds for Apple Silicon (M1). Making it start building the binary on install, which requires python@2. It think it would be great if node-sass could just be updated to v8.0.0.

kraenhansen avatar May 04 '23 19:05 kraenhansen

I tried upgrading this in the playground package.json and running rush update, but failed 😞

Running "pnpm install" in /Users/kraen.hansen/tsdoc/common/temp

Using hooks from: /Users/kraen.hansen/tsdoc/common/temp/pnpmfile.js
readPackage hook is declared. Manifests of dependencies might get overridden
 WARN  deprecated [email protected]: 3.x is no longer supported
Downloading registry.npmjs.org/typescript/3.9.9: 9.58 MB/9.58 MB, done
Downloading registry.npmjs.org/monaco-editor/0.17.1: 11.5 MB/11.5 MB, done
Downloading registry.npmjs.org/typescript/4.0.7: 9.94 MB/9.94 MB, done
Packages: +1256
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/kraen.hansen/tsdoc/common/temp/pnpm-store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 1253, reused 0, downloaded 1253, added 1256, done
node_modules/.pnpm/[email protected]/node_modules/fsevents: Running install script, done in 1s
node_modules/.pnpm/[email protected]/node_modules/ejs: Running postinstall script, done in 87ms
node_modules/.pnpm/[email protected]/node_modules/node-sass: Running install script, done in 417ms
node_modules/.pnpm/[email protected]/node_modules/node-sass: Running install script, done in 489ms
node_modules/.pnpm/[email protected]/node_modules/node-sass: Running postinstall script, failed in 2s

Is seem something is still depending on node-sass@4 but I can't seem to figure out what and running pnpm why node-sass in ./platground yields an empty result πŸ˜• @octogonz I think I need some help on this one.

kraenhansen avatar May 08 '23 12:05 kraenhansen