torchgeo icon indicating copy to clipboard operation
torchgeo copied to clipboard
verified publisher icon microsoft

Nlcd dataset issue

Open gatienc opened this issue 2 weeks ago • 2 comments

As discussed in #2877, this PR updates the link to download the NLCD dataset.

The dataset now provides a zip file containing the TIF file, so I used a similar method as in the Chesapeake dataset and updated the test file accordingly.

The dataset version on their website has been incremented. I haven't analyzed the changes further, but I tested the dataset by plotting it.

2024 data has also been added.

gatienc avatar Dec 09 '25 22:12 gatienc

Can we focus this PR on fixing downloads and open a separate PR to add 2024 data? The former can go into a 0.8.1 release soon but the latter should be saved for 0.9.0 since it changes a default.

adamjstewart avatar Dec 10 '25 13:12 adamjstewart

Oh nice catch, indeed, I haven't thought about that

gatienc avatar Dec 10 '25 23:12 gatienc

I think this can be made simpler. See CDL as an example.

adamjstewart avatar Dec 14 '25 15:12 adamjstewart

Indeed the CDL implementation is simpler!

Regarding the test coverage, should we add a test case to ensure an error is raised when the checksum is invalid?

gatienc avatar Dec 14 '25 18:12 gatienc

I would just copy the CDL tests.

adamjstewart avatar Dec 14 '25 18:12 adamjstewart