tolerant-php-parser icon indicating copy to clipboard operation
tolerant-php-parser copied to clipboard

Come up with better consistent names for getStart/getEndPosition

Open roblourens opened this issue 8 years ago • 2 comments

https://github.com/Microsoft/tolerant-php-parser/pull/156#discussion_r122614440

roblourens avatar Aug 07 '17 21:08 roblourens

In the meantime, could you add an alias to either of the classes? (e.g. add getStartPosition() to Node, keeping the existing getStart() method and maybe marking it as deprecated).

Adding a new alias should be backwards compatible, and lets users get an offset without doing an instanceof check

TysonAndre avatar Sep 23 '17 04:09 TysonAndre

The Node and Token methods were changed in #349

TysonAndre avatar Aug 10 '22 23:08 TysonAndre