thrifty icon indicating copy to clipboard operation
thrifty copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Support for THttpClient Transport

Open cyber-gh opened this issue 4 years ago • 4 comments

Are there any plans to support the THttpClient from the original thrift implementation?

cyber-gh avatar Jul 02 '20 12:07 cyber-gh

No current plans, but that's only because we haven't had that need. I'm not opposed to it, but don't personally have the time or inclination to do the work myself. I'd be happy to help guide a PR.

benjamin-bader avatar Jul 02 '20 20:07 benjamin-bader

I will give it a try, but this may take some time, as I have to document on this in topic

cyber-gh avatar Jul 05 '20 18:07 cyber-gh

@benjamin-bader I'm also interested in seeing this happen (especially given the server-side thrift stuff that looks to be landing soon). Can you point me to the places that I should start looking to build the new transport?

clayreimann avatar May 28 '21 16:05 clayreimann

Most transports live in https://github.com/microsoft/thrifty/tree/master/thrifty-runtime/src/commonMain/kotlin/com/microsoft/thrifty/transport.

For convenience you might start putting your code here, but I see a few issues to be resolved prior to merging:

  • this is "common" code and most HTTP libraries are platform-specific. Maybe OkHttp is multiplatform now?
  • a main goal of this project is to be as lightweight as possible in terms of method references. It may be desirable to put this transport into its own module.

benjamin-bader avatar May 28 '21 17:05 benjamin-bader

I think this can be close now as it was added in https://github.com/microsoft/thrifty/pull/449 :)

luqasn avatar Nov 16 '23 17:11 luqasn

Done!

benjamin-bader avatar Nov 16 '23 17:11 benjamin-bader