thrifty icon indicating copy to clipboard operation
thrifty copied to clipboard

Link to thrifty retrofit converter

Open reisub opened this issue 7 years ago • 4 comments

Hi Thrifty developers,

thanks for the great lib!

I implemented a retrofit converter for thrifty, can you please take a look at this retrofit PR?

I would be glad to adjust the coding style and make a PR to Thrifty if it makes sense for you to have the converter as part of this repository.

Thanks in advance

reisub avatar Jul 12 '17 16:07 reisub

This is pretty cool - nice work!

To mirror Jake's response to your PR, I also don't feel that we'd be good maintainers of this particular project - we don't use Thrift over HTTP at all, and almost certainly never will.

Would you be willing to publish this yourself? I'd be really happy to link to it.

benjamin-bader avatar Jul 13 '17 19:07 benjamin-bader

Okay, thanks for the feedback.

The converter is now published here (we're just waiting for it to be linked to jcenter): https://github.com/infinum/thrifty-retrofit-converter

Can you link to it?

reisub avatar Jul 18 '17 18:07 reisub

That's great! I'll have a link up soon.

benjamin-bader avatar Jul 18 '17 19:07 benjamin-bader

Hi @benjamin-bader, just a friendly reminder about this :)

reisub avatar Jul 02 '19 07:07 reisub