theme-converter-for-vs icon indicating copy to clipboard operation
theme-converter-for-vs copied to clipboard

Themes are not working in Visual studio 1.7.9.0+ versions

Open Petrarca181 opened this issue 1 year ago • 8 comments

Describe the bug Most of converted themes from Theme pack like Abyss or Dark+ are not working correctly anymore.

Expected behavior Work as on previous verisons?

Environment (please complete the following information):

  • Visual studio 1.7.9.0+
  • Theme used: [e.g. Dark+]

Impact Can't code anymore, I need my dark+ back :(

Petrarca181 avatar Feb 15 '24 09:02 Petrarca181

  • It seems most method calls aren't coloring correctly - only extension/static methods possibly?
  • The type and name of a variable are also the same color, which I'm pretty sure wasn't the case before.
  • I'm sure there are more, maybe someone else could chip in?

I'm trying to get before and after screenshots, if I can find a VS installation that hasn't been updated

Smenus avatar Feb 26 '24 11:02 Smenus

Adding to @Smenus's comment:

  • Interface names are not coloured when implementing the interface.
  • Used namespaces are not coloured.
  • Regular method calls are coloured regardless of whether they're static or not. Extension method calls are coloured.

Examples using the Dark+ theme:

In 17.9.1 (click to expand)

image

In 17.8 (click to expand)

image

Code (click to expand)
namespace VS_17_9_Themes
{
    // Usings are not coloured.
    using System;
    using System.Net.Http;

    public static class Program
    {
        public static void Main(string[] args)
        {
            SomeClass someClass = new();

            // Regular method calls are not coloured.
            someClass.RegularMethodOnOtherClass();
            RegularMethodOnSameClass();

            // Extension method calls are coloured.
            someClass.ExtensionMethodOnOtherClass();
        }

        public static void RegularMethodOnSameClass()
        {
            Console.WriteLine("Hello");
        }
    }

    public interface ISomeInterface { }
    public class SomeClassBase { }

    public class SomeClass
        // Interface names are not coloured.
        : SomeClassBase, ISomeInterface
    {
        public void RegularMethodOnOtherClass()
        {
            Console.WriteLine("Hello");
        }
    }

    public static class SomeClassExtensions
    {
        public static void ExtensionMethodOnOtherClass(this SomeClass someClass)
        {
            Console.WriteLine("Hello");
        }
    }
}

salkriaf34 avatar Feb 26 '24 13:02 salkriaf34

I glad I'm not alone. Sadly I was allarming about this since thems stoped working in preview branch. Looks like no one cares about this issue. I also doubt someone from devlabs team will see the bug report....

If you didn't see my reddit post this is some sort of solution:

  1. Download and install Carnation extension.
  2. Apply Broken theme
  3. Open Carnation window
  4. Press "Themes" apply any theme from there.
  5. Press "Themes" than "Reset theme to default"
  6. Voila! Your theme is fixed!

Petrarca181 avatar Feb 26 '24 14:02 Petrarca181

@salkriaf34

Please hide images/long code under spoilers WOW this is spoiler!

Examples

Petrarca181 avatar Feb 26 '24 14:02 Petrarca181

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot

image

salkriaf34 avatar Mar 15 '24 19:03 salkriaf34

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot

you are my hero!

Petrarca181 avatar Mar 16 '24 09:03 Petrarca181

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic.

Screenshot

This kind of fixed it for me as well. Thank you!

abel-nagy avatar Mar 18 '24 10:03 abel-nagy

A fix from the VS team is coming: https://developercommunity.visualstudio.com/t/Identifier-has-too-high-priority-in-sy/10547451

The workaround that worked for me was setting the Identifier background and foreground to Automatic. Screenshot

Legend

a-milburn avatar Apr 26 '24 01:04 a-milburn