microsoft
Add `VSTestBridge` msbuild capability for VS and runsetting handling
We should announce to VS if pass or not the runsetting. If adapter is using the VSTestBridge it's handled automatically, otherwise is ignored.
~~This means rename also the --settings to something mode specific --runsettings or at least have it fixed and hidden to let VS to correctly compose.~~
Could you give a little more details of what would need to be done? Create a capability? Transfer it in server mode? ...
Could we reuse https://github.com/microsoft/testfx/blob/main/src/Platform/Microsoft.Testing.Extensions.VSTestBridge/Capabilities/IVSTestFlattenedTestNodesReportCapability.cs?
Could you give a little more details of what would need to be done? Create a capability? Transfer it in server mode? ...
We need to set a capability in MSBuild props for that extension so VS can take it and decide if pass or not the runsettings.
We need to set a capability in MSBuild props for that extension so VS can take it and decide if pass or not the runsettings.
This is going to be problematic for now as xunit uses the runsettings env variable (and it doesn't use the bridge) to decide whether or not source info should be calculated.
I also think that VSTestBridge should be killed, we should move MSTest's MTP implementation away from the bridge, and push NUnit and Expecto to move as well.
UPDATE: xunit will no longer rely on the runsettings env variable in xunit.v3 3.x as they switched to using caller info attributes. However, I think the bridge should be completely killed eventually. So I still feel we shouldn't do anything here for now.
Should we close this?
I also think that VSTestBridge should be killed, we should move MSTest's MTP implementation away from the bridge, and push NUnit and Expecto to move as well.
This