terraform-provider-azuredevops icon indicating copy to clipboard operation
terraform-provider-azuredevops copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Add Wiki Resource

Open Bjorninator opened this issue 2 years ago • 9 comments

All Submissions:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] My code follows the code style of this project.
  • [x] I ran lint checks locally prior to submission.
  • [x] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Added the resource that a wiki can be added through terraform. Allowing for easier initial setup of Azure Devops environments with Terraform. Currently we have to clickops this together.

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • [x] Yes
  • [ ] No

API for these calls that make use of the wiki are not yet added

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

Bjorninator avatar Jan 24 '23 10:01 Bjorninator

@microsoft-github-policy-service agree

Bjorninator avatar Jan 24 '23 10:01 Bjorninator

@xuzhang3 Added the acceptance test and made the code changes as requested.

Bjorninator avatar Feb 27 '23 13:02 Bjorninator

hi @xuzhang3, if all the conflict can be resolved and all the test case pass describe above. Is this wiki feature PR can be merge in the near milestone? Thank you.

chienfuchen32 avatar Mar 28 '24 14:03 chienfuchen32

chienfuchen32

yes, after the conflict resolved, review change updated and the tests passed, this PR can be merged

xuzhang3 avatar Mar 29 '24 03:03 xuzhang3

@xuzhang3 thank you. I've tried merge this locally, the wiki functionality works fine for me. Unfortunately, what I was looking for is wiki page, this might enhance documentation sharing via Terraform from code to human-readable document. If I'd like to implement wiki page feature on my own, should I submit wiki PR first? any guideline I could probably follow? thanks a lot.

chienfuchen32 avatar Apr 11 '24 12:04 chienfuchen32

@xuzhang3 thank you. I've tried merge this locally, the wiki functionality works fine for me. Unfortunately, what I was looking for is wiki page, this might enhance documentation sharing via Terraform from code to human-readable document. If I'd like to implement wiki page feature on my own, should I submit wiki PR first? any guideline I could probably follow? thanks a lot.

If wiki page depends on the wiki resources, you need to create the wiki page based on this PR. You can ping @Bjorninator to see if you can continue your work based on his PR and you can submit all of the new features in another PR

xuzhang3 avatar Apr 12 '24 03:04 xuzhang3

Hi @Bjorninator, would you continue to finish this wiki feature? I'd like to add wiki page based on this. please share with us if you have any thought. Many thanks!

chienfuchen32 avatar Apr 12 '24 12:04 chienfuchen32

@Bjorninator if you are not available to update this PR, can we fork you PR and continue the works based on your PR? @chienfuchen32

xuzhang3 avatar Apr 16 '24 02:04 xuzhang3

Hi @xuzhang3, I might fork this and send another PR and submit a Wiki page feature issue soon, hope we could have some discussion then. Thanks.

chienfuchen32 avatar Apr 19 '24 14:04 chienfuchen32