terraform-provider-azuredevops icon indicating copy to clipboard operation
terraform-provider-azuredevops copied to clipboard

feat: Azure devops service connections for maven, jenkins and nexus

Open Cyb3rDudu opened this issue 2 years ago • 5 comments

All Submissions:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] My code follows the code style of this project.
  • [x] I ran lint checks locally prior to submission.
  • [x] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Implements Service Endpoints for Maven, Jenkins and Nexus IQ Added:

  • resource azuredevops_servicehook_maven
  • acceptance tests for azuredevops_servicehook_maven resource
  • resource azuredevops_servicehook_jenkins
  • acceptance tests for azuredevops_servicehook_jenkins resource
  • resource azuredevops_servicehook_nexus
  • acceptance tests for azuredevops_servicehook_nexus resource

Acc Test

=== RUN   TestServiceEndpointMaven_ExpandFlatten_RoundtripPassword
--- PASS: TestServiceEndpointMaven_ExpandFlatten_RoundtripPassword (0.00s)
=== RUN   TestServiceEndpointMaven_ExpandFlatten_RoundtripToken
--- PASS: TestServiceEndpointMaven_ExpandFlatten_RoundtripToken (0.00s)
=== RUN   TestServiceEndpointMaven_Create_DoesNotSwallowErrorToken
--- PASS: TestServiceEndpointMaven_Create_DoesNotSwallowErrorToken (0.00s)
=== RUN   TestServiceEndpointMaven_Create_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointMaven_Create_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointMaven_Read_DoesNotSwallowErrorToken
--- PASS: TestServiceEndpointMaven_Read_DoesNotSwallowErrorToken (0.00s)
=== RUN   TestServiceEndpointMaven_Read_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointMaven_Read_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointMaven_Delete_DoesNotSwallowErrorToken
--- PASS: TestServiceEndpointMaven_Delete_DoesNotSwallowErrorToken (0.00s)
=== RUN   TestServiceEndpointMaven_Delete_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointMaven_Delete_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointMaven_Update_DoesNotSwallowErrorToken
--- PASS: TestServiceEndpointMaven_Update_DoesNotSwallowErrorToken (0.00s)
=== RUN   TestServiceEndpointMaven_Update_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointMaven_Update_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointNexus_ExpandFlatten_RoundtripPassword
--- PASS: TestServiceEndpointNexus_ExpandFlatten_RoundtripPassword (0.00s)
=== RUN   TestServiceEndpointNexus_Create_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointNexus_Create_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointNexus_Read_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointNexus_Read_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointNexus_Delete_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointNexus_Delete_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointNexus_Update_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointNexus_Update_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointJenkins_ExpandFlatten_RoundtripPassword
--- PASS: TestServiceEndpointJenkins_ExpandFlatten_RoundtripPassword (0.00s)
=== RUN   TestServiceEndpointJenkins_Create_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointJenkins_Create_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointJenkins_Read_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointJenkins_Read_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointJenkins_Delete_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointJenkins_Delete_DoesNotSwallowErrorPassword (0.00s)
=== RUN   TestServiceEndpointJenkins_Update_DoesNotSwallowErrorPassword
--- PASS: TestServiceEndpointJenkins_Update_DoesNotSwallowErrorPassword (0.00s)

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • [ ] Yes
  • [x] No

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Any relevant logs, error output, etc?

Other information

Locally built and tested manually.

Cyb3rDudu avatar Jul 05 '22 10:07 Cyb3rDudu

CLA assistant check
All CLA requirements met.

@jamu85 please help resolve the conflict

xuzhang3 avatar Jul 29 '22 07:07 xuzhang3

@xuzhang3 the conflicts are resolved

Cyb3rDudu avatar Aug 02 '22 07:08 Cyb3rDudu

Test case TestAccServiceEndpointNexus_RequiresImportErrorStepUsernamePassword not pass

=== RUN   TestAccServiceEndpointNexus_RequiresImportErrorStepUsernamePassword
=== PAUSE TestAccServiceEndpointNexus_RequiresImportErrorStepUsernamePassword
=== CONT  TestAccServiceEndpointNexus_RequiresImportErrorStepUsernamePassword
    resource_serviceendpoint_nexus_test.go:84: Step 2/2, expected an error but got none
--- FAIL: TestAccServiceEndpointNexus_RequiresImportErrorStepUsernamePassword (74.06s)
FAIL
FAIL    github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        76.679s
FAIL
make: *** [testacc] Error 1

xuzhang3 avatar Aug 02 '22 09:08 xuzhang3

@jamu85 lint CI failed image

xuzhang3 avatar Aug 16 '22 08:08 xuzhang3