terraform-provider-azuredevops icon indicating copy to clipboard operation
terraform-provider-azuredevops copied to clipboard

feat: add a new resource azuredevops_environment_resource_kubernetes

Open croemmich opened this issue 2 years ago • 11 comments

All Submissions:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] My code follows the code style of this project.
  • [x] I ran lint checks locally prior to submission.
  • [x] Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Added the ability to manage Kubernetes environment resources.

Introduced a new TaskAgentKubernetesResourceClient that provides a re-implementation of the taskagent.AddKubernetesResource method to allow passing the serviceEndpointId parameter, which is required by the API but cannot be passed via the official SDK implementation.

I've created microsoft/azure-devops-go-api#116 to track the issue with the official SDK.

Does this introduce a change to go.mod, go.sum or vendor/?

  • [ ] Yes
  • [x] No

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

croemmich avatar Mar 05 '22 06:03 croemmich

CLA assistant check
All CLA requirements met.

@croemmich if this PR not ready, you can change it to draft.

xuzhang3 avatar Mar 09 '22 07:03 xuzhang3

@xuzhang3, I've updated this PR with a new client implementation that allows for adding a Kubernetes environment resource against an existing serviceEndpointId. Let me know what you think. I don't have high hopes microsoft/azure-devops-go-api#116 will be resolved very quickly.

croemmich avatar Mar 10 '22 20:03 croemmich

Hi @xuzhang3, anything you need from me to get this merged? Thanks!

croemmich avatar Mar 16 '22 20:03 croemmich

@croemmich I prefer SDK fix this bug then we merge this PR. Private client is a workaround but not our best choice.

xuzhang3 avatar Mar 17 '22 09:03 xuzhang3

@croemmich, @xuzhang3 any update on this PR, we really need this enhancement to be merged for our use case also. Appreciate your help.

thatham avatar Aug 30 '22 12:08 thatham

@croemmich, @xuzhang3 any update on this PR, we really need this enhancement to be merged for our use case also. Appreciate your help.

This PR is blocked by SDK. SDK issue: https://github.com/microsoft/azure-devops-go-api/issues/116

xuzhang3 avatar Aug 31 '22 02:08 xuzhang3

@thatham, unfortunately I'm not a Microsoft employee so I've no levers to pull. This was contributed this 5 months ago and there's still no progress.

@xuzhang3, this isn't totally blocked, you didn't want my custom taskagentkubernetesresource client, which I get, however as far as I'm concerned the SDK is dead... it's not been touched since Jan 26, and calling it supported before that was dubious at best. This terraform provider is 100x more important to us than the SDK. If this were my project I'd certainly not get hung up on relativity easy to fix SDK limitations/bugs.

croemmich avatar Aug 31 '22 05:08 croemmich

@croemmich @thatham Sorry for the delay response. Office SDK will be our first choice if this SDK still available otherwise I'd like to generate a private SDK based on the swagger instead of fix the bug out of SDK and included as local file, . I know that there are many APIs not documented or the swagger definition is not correct.

Private SDK used in AzureRM: https://github.com/hashicorp/terraform-provider-azurerm/tree/main/internal/services/disks/sdk

xuzhang3 avatar Sep 01 '22 09:09 xuzhang3

@xuzhang3, do you have any estimated date of the corresponding fix to be merged in official SDK? @croemmich, kindly advise will this private SDK will help rollout your enhancements. I'm very desperate to get this changes.

thatham avatar Sep 01 '22 10:09 thatham

@thatham sorry I do not have the timeline, latest info I got is v7.1 will be released around Otc. ping @nechvatalp

xuzhang3 avatar Sep 05 '22 07:09 xuzhang3

@nechvatalp any update on this PR, we really need this enhancement to be merged for our use case also. Appreciate your help.

thatham avatar Nov 02 '22 11:11 thatham