microsoft
open new tab icon at the top title is not centered correctly
Windows Terminal version
1.19.10821.0
Windows build number
10.0.22631.3447
Other Software
No response
Steps to reproduce
its hard to notice it but if you set "Use acrylic material in the tab row" to true it becomes highly noticable
Expected Behavior
open a new tab icon to be centered
Actual Behavior
open a new tab icon is not centered
Huh, good eye.
Code is somewhere around here:
https://github.com/microsoft/terminal/blob/99061ee272b72c6d565802068f7b09ab12e4173e/src/cascadia/TerminalApp/TabRowControl.xaml#L48-L70
IIRC we're adding some margin to make the + centered nicely, but that code hasn't been touched in years so I may be off base on that
I think the SplitButton component doesn't support customizing the spacing for the secondary button: https://github.com/microsoft/microsoft-ui-xaml/issues/5605.
Currently, it has the padding hardcoded: https://github.com/microsoft/microsoft-ui-xaml/blob/7180ad3d3998bcbf2c8fa028ffb1ce3049d78228/dev/SplitButton/SplitButton.xaml#L297. And the icon always aligned to the right.
When the button has the default secondary button size, it renders the icon centered properly.
For other sizes, it renders wrong.
Would using the default size be ok?
