terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

window explorer (and terminal) hangs when I edit the address bar in a file picker

Open KamenRevice opened this issue 10 months ago • 4 comments

Windows Terminal version

1.19.10573.0

Windows build number

10.0.19045

Other Software

Windows explore image

Steps to reproduce

In the icon option for editing a single profile, after using the browse option and opening window explorer, it is not possible to enter the path to the file directly in the address bar, it is not possible to enter any characters, which causes the entire Windows terminal to go down, and the only way to close the program is to close it through task management. please look the gif animation

Expected Behavior

image

Actual Behavior

software is dead

KamenRevice avatar Apr 07 '24 10:04 KamenRevice

Hmm. We once had a similar report in #8957, but that was when users were running the Terminal elevated, and was also fixed in like, 1.7.

There was also #9984, which sounds almost exactly the same, but OP disappeared on that one.

I also can't repro this here on Windows 11.

Filing /feedback with the Feedback hub (but with the area set to like, "Files and Online Storage > File Explorer") may work to get a trace:

image

zadjii-msft avatar Apr 15 '24 11:04 zadjii-msft

Here's a link to the feedback recorded in the feedback center Does this have anything to do with the network driver clouddriver2 that I installed

KamenRevice avatar Apr 23 '24 06:04 KamenRevice

Huh. Interestingly enough, it looks like you're the only one who's hit this?

  • Apparently I can't promote the feedback hub feedback to an MSFT: work item. That's weird, but I think we're changing some backend bits.
  • I can still get to feedback ID 9a191c39-d40a-4559-82ed-d23e3cfec3a1
  • It's got three .dmps for explorer.exe,
  • and a link to a bucket: 1568601951875420617 (BucketDetails?BucketIdentifier=1568601951875420617).
    • There's only exactly one hit for this specific bucket in the last 90 days.
    • It's a moapphang in microsoft.windowsterminal_1.19.10821.0_x64__8wekyb3d8bbwe, and we have other moapphang's hanging around too, but I don't think they're related
    • There's nothing else interesting in the bucket...

zadjii-msft avatar May 07 '24 11:05 zadjii-msft

Dustin repro'd this instantaneously on Windows 10, and Leonard thinks... I think this code is the problem:

https://github.com/microsoft/terminal/blob/49e4eea60f737b46b8aeda505f4693df8a9d44a6/src/cascadia/WinRTUtils/inc/Utils.h#L15-L55

https://github.com/microsoft/terminal/blob/49e4eea60f737b46b8aeda505f4693df8a9d44a6/src/cascadia/TerminalSettingsEditor/Profiles_Base.cpp#L109-L125

Those sorta attempt to do the work async, but actually don't make it async at all

zadjii-msft avatar May 08 '24 21:05 zadjii-msft

Really? Did you locate the bug so quickly, and how long will it take to fix it, please?

KamenRevice avatar May 23 '24 10:05 KamenRevice

I have no idea if that's the actual source of the bug or not. We had coincidentally just been chatting about how this particular code didn't work as expected. And it sure seems like this is the kind of thing that might cause this bug.

No ideas how long it would take to fix. It might not even be the correct source of the bug 🤷

zadjii-msft avatar May 24 '24 16:05 zadjii-msft