terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Drop-down options in Settings always follow system theme

Open bzzrak opened this issue 1 year ago • 3 comments

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621.1702

Other Software

No response

Steps to reproduce

  1. set the WT theme to be the opposite of your system theme. In my case, system theme is light but Terminal is set to dark.
  2. open Settings
  3. click any option that has a drop-down.

Expected Behavior

The application theme is followed, in my case dark.

Actual Behavior

The system theme is followed, in my case light (on the right is the Settings app showing that my system theme is light.) image image

bzzrak avatar May 25 '23 02:05 bzzrak

I'm sure this is one of the many "we need to iterate through the XAML tree and the popup root to set the theme too" bugs we've dealt with for... basically forever. There's other similar issues scattered across the repo.

zadjii-msft avatar May 31 '23 21:05 zadjii-msft

May I take a look into this issue?

RickleAndMortimer avatar Aug 13 '23 21:08 RickleAndMortimer

@RickleAndMortimer Sorry about that! I must've missed that comment before. Please, always feel free to start on whatever ☺️

https://github.com/microsoft/terminal/pull/9732 might have some pointers of the right direction to investigate. Basically, anything that's a Popup doesn't share the same XAML root as the rest of the app, so we need to apply the RequestedTheme to popups manually 🙃

zadjii-msft avatar Feb 06 '24 21:02 zadjii-msft