[1.17] Launch Params in SUI needs a little cleanup

[carlos-zamora]

Bug 1: Launch Params resizes as you type X/Y val

Duped to #13495

Then when you click off of it, it looks like the num box buttons appear over the text? Weird.

Bug 2: rework Launch Params preview

I still feel like "Default,Default" should be something like…

"Let system position window" or "system position" or whatever

Should "Use system default" be renamed to "Let system position window"

[ianjoneill]

I think bug 1 may be a dupe of #13495 - the history size input does exactly the same thing.

[zadjii-msft]

I think bug 1 may be a dupe of https://github.com/microsoft/terminal/issues/13495

Yes it is

Should "Use system default" be renamed to "Let system position window"

absolutely yes

[carlos-zamora]

@zadjii-msft Hmm... Since #13495 is tracking upgrading to WinUI 2.8 (which would fix the bug, of course, but it's a lot of extra work). How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

[zadjii-msft]

How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

I mean, would it? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea?

[carlos-zamora]

How do we feel about changing the SpinButtonPlacementMode from Inline to Compact? I assume that fixes the problem and it would be super simple.

I mean, would it? I'm honestly fine leaving that half of the bug as is (and waiting for eventually figuring out winui 2.8), it only happens with huge numbers anyways, yea?

I did the thing: #14569

[ghost]

:tada:This issue was addressed in #14569, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

• Release Notes
• Store Download