terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Fix issues with Japanese & Vietnamese IME

Open lhecker opened this issue 3 years ago • 2 comments

This commit builds directly on the changes made in #13677 and fixes:

  • TSF resetting to AlphaNumeric ("ASCII") input mode when pressing enter
  • Vietnamese IME not composing a new word after pressing whitespace, etc.

Closes #11479 Closes #13398

Validation Steps Performed

  • Japanese IME (Full-Width Katakana) Typing "saitama" produces "サイタマ" ✅
  • Korean IME Typing "gksrmf" produces "한글" ✅
  • Vietnamese IME Typing "xin chaof" produces "xin chào" ✅
  • Emoji Picker (Win+.) ✅

lhecker avatar Aug 04 '22 23:08 lhecker

I wasn't sure whether I should integrate these changes into the changes made in #13677. I guess keeping it seperate has the benefit of being easier to backport if we don't trust the changes in the other PR. 🙂

lhecker avatar Aug 04 '22 23:08 lhecker

This needs a merge or rebase

DHowett avatar Aug 08 '22 18:08 DHowett

(this is a test)

@msftbot merge this after #13707 merges

zadjii-msft avatar Aug 11 '22 21:08 zadjii-msft

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Aug 11 '22 21:08 ghost

:tada:Windows Terminal Preview v1.15.228 has been released which incorporates this pull request.:tada:

Handy links:

ghost avatar Aug 17 '22 23:08 ghost