terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Update to WinUI 2.8 (was: History size overlaps with widget controls)

Open elsaco opened this issue 2 years ago • 2 comments

Windows Terminal version

1.15.1863.0

Windows build number

10.0.22000.778

Other Software

No response

Steps to reproduce

Enter a large history size, INT_MAX used for testing

Expected Behavior

No overlapping

Actual Behavior

max_history_size

maintainer note

Also:

  • [ ] #9822

elsaco avatar Jul 13 '22 00:07 elsaco

isn't this it https://github.com/microsoft/microsoft-ui-xaml/issues/5983 ?

serd2011 avatar Jul 17 '22 04:07 serd2011

Sure looks like it to me, thanks! We haven't had an opportunity to move to WinUI 2.8 yet, but I'm gonna tentatively use this to track upgrading. We also need to do this to fix the crashes associated with #12413 in downlevel OS versions.

zadjii-msft avatar Jul 18 '22 11:07 zadjii-msft

Taking this out of 1.16, cause it seems like there's a lot of issues with 2.8 and we don't have the runway to sort them all out. The important bit, the #12413 crash, we're gonna fix with a minor hotfix to 2.7.

zadjii-msft avatar Aug 16 '22 11:08 zadjii-msft