terminal
terminal copied to clipboard
Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?)
Windows Terminal version
1.13.10395.0
Windows build number
10.0.19044
Other Software
No response
Steps to reproduce
- Open Windows Terminal
- Click outside of window to lose focus and make the window inactive
Expected Behavior
Current tab would go grey Caption buttons would go grey
Actual Behavior
Neither titlebar element go grey
Generally, I've been duping these to #4862. However, I totally missed the one other checkbox in #1625 about the caption button colors, so I'm gonna re-purpose this issue to track that element. Thanks!
Note
Walkthrough
To do this, we'd need to:
- Listen for a
WM_NCACTIVATE
inIslandWindow
- Plumb that as an event up to
AppHost
- Call a new method on
AppLogic
, which plumbs that down toTerminalPage
to tell them that the window was activated/inactivated - in
TerminalPage
, when_settings.GlobalSettings().ShowTabsInTitlebar()
is true, call toMinMaxCloseControl
inTitlebarControl
to tell it the window is no longer active - There, change the color of the buttons when the window is activated/deactivated.
See also #10401, which never got finished.
I'm psyched to see that #4862 was implemented. Is this still being worked on?
Is this still being worked on?
Not currently, but it seems fairly trivial these days. The plumbing in #4862 should make it trivial.
proposed "schema":
captionButtons: {
foreground: ThemeColor,
background: ThemeColor (default: #00000000),
unfocusedForeground: ThemeColor,
unfocusedBackground: ThemeColor (default: #00000000),
}
I don't really think we need to have separate knobs for each of the buttons.
I may take a stab at this one if that is ok.
@jamespack Go for it!