terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Ctrl+Shift+W doesn't work if Ctrl key is remapped.

Open kasajian opened this issue 4 years ago • 6 comments

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

SharpKeys

Steps to reproduce

  1. Install SharpKeys (or some other similar app) that maps the Caps+Lock key to the Ctrl key
  2. open Windows Terminal, and create a tab or a pane.
  3. Attempt to close the tab or pane with Ctrl+Shift+W (using the Caps+Lock key instead of the Ctrl iey)

Expected Behavior

pane or tab should close

Actual Behavior

It doesn't close. But if you use the actual Ctrl key, it will work.

Please note that this is not SharpKeys related. That product simply helps construct the data that needs to be placed in the registry. The key mapping is a Windows feature.

kasajian avatar Sep 05 '21 06:09 kasajian

@lhecker I suspect that this will be interesting to you!

DHowett avatar Sep 07 '21 15:09 DHowett

Same problem, Windows Terminal Version: 1.11.3471.0, remapping by SharpKeys (modify Registry)

I just failed to use Ctrl+Spacebar because remapped Ctrl to CapsLock. The original Ctrl works.

UPDATE: 1.12.10393.0 still not work

UPDATE: For laptop, remapped Ctrl works on external keyboard, neither original nor remapped Ctrl works on internal keyboard; for PC, it has only external keyboard so the remapped key works. I don't understand..

hsupu avatar Dec 26 '21 11:12 hsupu

@kasajian thanks for posting, thought I was going crazy experiencing the same thing.

manifestinteractive avatar Feb 13 '22 20:02 manifestinteractive

I noticed that the remapped Caps Lock doesn't work right in this case on my work machine, but on my personal machine using PowerToys Keyboard Manager I'm not having the same issue.

Personal machine Attaching the system info for my personal thinkpad t480 running Windows 10. systeminfo.txt

Keyboard Manager right now is ~~0.70.1~~ 0.74.1 - installed via winget - and my configuration is minimal: image

Work machine It's a Dell 5420 - not attaching more details. My work doesn't let me install PowerToys so I've tried AHK instead.

jcrben avatar Oct 14 '23 20:10 jcrben

How can we get this to be fixed?

The developers who wrote this clearly aren't handling the Ctrl key the right way. It's fine. Mistakes happen. But why not fix it after you're told about it?

It's been like 3 years.

How do we get this thing attention?

kasajian avatar Oct 16 '24 18:10 kasajian

Anyone is welcome to investigate yourself what's up here. The code that handles keybindings is right here:

https://github.com/microsoft/terminal/blob/3a06826915d11ee2124de9b35e42300e1c3f68d5/src/cascadia/TerminalControl/TermControl.cpp#L1749

That's where I'd start with a breakpoint.

There's but a single 👍 on this issue, which means this probably isn't bubbling to the top of our list of priorities any time soon. But we'd be happy to review a fix

zadjii-msft avatar Oct 16 '24 19:10 zadjii-msft