snmalloc icon indicating copy to clipboard operation
snmalloc copied to clipboard
verified publisher icon microsoft

upstream snmalloc-rs as part of snmalloc

Open SchrodingerZhu opened this issue 10 months ago • 5 comments

SchrodingerZhu avatar Feb 07 '25 14:02 SchrodingerZhu

is this still in progress?

jayakasadev avatar Mar 21 '25 19:03 jayakasadev

I am still okay with this and I can continue contributing to the rust part at upstream.

If this is the decided approach to go, I will archive the downstream and put a pointer to upstream in its README.

SchrodingerZhu avatar Mar 21 '25 20:03 SchrodingerZhu

Pros and cons on top of my head:

Pros

  1. Easier to sync up.
  2. Unified CI to make sure everything works

Cons

  1. CXX project will need to pull in extra rust code.
  2. Loss of downstream history

Some other issues:

Maybe it is better to unify the versions in some future releases.

SchrodingerZhu avatar Mar 21 '25 20:03 SchrodingerZhu

Additional pro: Bazel users can directly depend on the snmalloc-rs target (assuming the pr is merged). They won't have to add both.

jayakasadev avatar Mar 22 '25 13:03 jayakasadev

Cons

2. Loss of downstream history

You could look into git subtree merge if you want to preserve the history. There are some tangentially applicable docs on that in https://docs.freebsd.org/en/articles/committers-guide/#vendor-import-git

kev009 avatar May 07 '25 19:05 kev009