slow-cheetah icon indicating copy to clipboard operation
slow-cheetah copied to clipboard

Is Release 4.12 available on nuget.org? 4.08 Flagged as Security issue

Open IanGoddard opened this issue 3 years ago • 8 comments

SlowCheetah 4.0.8 is the only version on nuget.org which comes packages with newtonsoft.json 9.0.1. This is being flagged by static code analysis tools as a security vulnerability.

This is fixed in release 4.0.12 however, this has not been pushed to nuget and therefore means that SlowCheetah 4.0.8 and 3.2.26 are both not allowed to be used by teams that maintaining security best practises against software vulnerabilities.

The release folder contains source code for 4.0.12 but the released version on nuget is 4.0.8 and there are no beta versions available.

Sonatype-2021-0713 was related to a potential stack overflow that could cause a DoS attack and was fixed in newtonsoft.json version 13.0.1. However it seems that Microsoft has not updated the SlowCheetah package to use the newly fixed version of NewtonSoft.json.dll and continues to use version 9.0.1.19813 in both the 3.2.26 and 4.0.8 versions of SlowCheetah.

IanGoddard avatar Jan 12 '22 15:01 IanGoddard

+1 We have the same issue. Is there any update or ETA on this?

molekamp avatar Feb 17 '22 15:02 molekamp

Same issue here. When can 4.0.12 be released to nuget to mitigate this vulnerability?

LB1979-dev avatar May 02 '22 20:05 LB1979-dev

@adrianvmsft Is there any way to release the 4.0.12 nuget?

tsprouls avatar Jul 20 '22 13:07 tsprouls

Bump.

The source code for tag v4.0.12 has Newtonsoft.Json 13.0.1 image

The Newtonsoft.Json DLL packaged on nuget is still showing 9.0.1. (Scanners are also seeing the version as 9.0.1, as @IanGoddard mentioned) image

zdfowler avatar Aug 19 '22 15:08 zdfowler

Any updates on this

mrpolaris avatar Aug 25 '22 18:08 mrpolaris

Still looking for a 4.0.12 release to NuGet.

SteveQueenMarquam avatar Oct 11 '22 21:10 SteveQueenMarquam

+1, no solution for non-Visual Studio user I assume?

vancouverbcd avatar Oct 27 '22 20:10 vancouverbcd

Appears that the https://github.com/microsoft/slow-cheetah/tree/v4.0.50 release includes https://github.com/microsoft/slow-cheetah/commit/7ae268bac0b361737af7a32eb7db84233d665de7, which updates Newtonsoft to 13.0.01

4.0.52 hasn't been pushed to NuGet, but for the purposes of this issue, since 4.0.50 includes the fix I'd call it closed as soon as someone can get to it.

zdfowler avatar Jul 14 '23 19:07 zdfowler