service-fabric-cli icon indicating copy to clipboard operation
service-fabric-cli copied to clipboard

Add --sort-order option to upgrade commands

Open hans-olav opened this issue 5 years ago • 3 comments

This change adds the --sort-order option that is new to SF 6.5 to all upgrade commands. Done with manual testing, still working on CI tests - wanted to get this out for early feedback first.

Help text output:

sfctl cluster upgrade -h
sfctl application upgrade -h
...
--sort-order      : Defines the order in which an upgrade proceeds through
                         the cluster. Possible values: 'Default', 'Numeric',
                         'Lexicographical', 'ReverseNumeric',
                         'ReverseLexicographical'.  Default: Default.
...

Example commands manually tested:

sfctl cluster upgrade --config-version v3 --sort-order ReverseNumeric

sfctl application upgrade --application-id CalculatorActorAppType --application-version 3.0.0 --parameters "{}" --sort-order ReverseLexicographical

Verified:

  • [ ] In progress: Build and test CI passes
  • [X] History and readme updated to reflect changes
  • [ ] N/A: Package version updated according to semantic versioning rules
  • [X] Tests modified or added, when applicable
  • [ ] N/A: Updated code owners file, when applicable
  • [X] Read the PR checklist

hans-olav avatar May 17 '19 00:05 hans-olav

CLA assistant check
All CLA requirements met.

msftclas avatar May 17 '19 00:05 msftclas

@hans-olav can you please also join the correct Microsoft organizations so you appear as an MS employee?

samedder avatar May 22 '19 18:05 samedder

FYI you can do this also using the JMESPath CLI option, it allows "sort" expressions

samedder avatar May 22 '19 18:05 samedder