semantic-link-labs icon indicating copy to clipboard operation
semantic-link-labs copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

deploy report

Open m-kovalsky opened this issue 9 months ago • 1 comments

m-kovalsky avatar Mar 11 '25 20:03 m-kovalsky

LGTM! This PR adds a useful deploy_report function, which looks like a great addition for managing report lifecycles. The refactoring of clone_report to use standardized helpers and support UUIDs is also a good improvement.

A couple of minor points to make it easier for the people who review PRs here:

  1. Consider adding a brief description to the PR explaining the motivation and summarizing the changes.
  2. In _report_functions.py, the docstring for clone_report could explicitly mention that it will not overwrite an existing report and will issue a warning instead. This clarifies the intended behavior compared to deploy_report.

Overall, nice work!

a-holm avatar Mar 30 '25 14:03 a-holm

@a-holm I don't think we need this anymore as I created a generic copy_item function.

m-kovalsky avatar Oct 28 '25 11:10 m-kovalsky