semantic-link-labs icon indicating copy to clipboard operation
semantic-link-labs copied to clipboard

Added ability to target all Fabric data store types with create_shortcut_onelake

Open crazy-treyn opened this issue 1 year ago • 3 comments

Initially the create_shortcut_onelake function only allowed targeting a Lakehouse as a source. However, the APIs being used to create shortcuts can target any itemId.

This PR includes updates to support creating shortcuts to any kind of Onelake data store item type; Lakehouse, Warehouse, MirroredDatabase, KQLDatabase, and SQLDatabase.

Note: The parameter structure of the function had to change slightly, including names of parameters and a new parameter for the data store type. This will break existing implementations using the original parameter structure of the create_shortcut_onelake function.

crazy-treyn avatar Feb 22 '25 05:02 crazy-treyn

@microsoft-github-policy-service agree

crazy-treyn avatar Feb 22 '25 05:02 crazy-treyn

Updated. I also made a similar change resolving the name and id of the destination lakehouse using the same resolve_item_name_and_id function for consistency.

crazy-treyn avatar Feb 25 '25 14:02 crazy-treyn

@m-kovalsky I think this is ready for merge, but please let me know if there's anything else I need to change.

crazy-treyn avatar Jun 07 '25 14:06 crazy-treyn