semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

UI in chatapp will not show input correctly when input is in state

Open poweihuang0817 opened this issue 1 year ago • 2 comments

Describe the bug Sample UI should get input from state as fallback.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • IDE: [e.g. Visual Studio, VS Code]
  • NuGet Package Version [e.g. 0.1.0]

Additional context Add any other context about the problem here.

poweihuang0817 avatar May 15 '23 17:05 poweihuang0817

image

poweihuang0817 avatar May 15 '23 17:05 poweihuang0817

This seems like an ActionPlanner bug. It is placing SoP_High_Memory into the Plan.State which gets overridden by the input when the plan is executed (Yes, proceed). LIke SequentialPlanner, this should be a Parameter on the step where this should be input.

https://github.com/microsoft/semantic-kernel/blob/f1448c9a0759947256af7f4c6b940c9eab06ea91/dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs#L127

lemillermicrosoft avatar May 18 '23 15:05 lemillermicrosoft

The Input not showing in the copilot chat app as a bug that was fixed I believe. Please re-activate or open a new issue if still experiencing issues. cc @teresaqhoang to confirm. Will track the ActionPlanner issue in #997

lemillermicrosoft avatar Jun 15 '23 21:06 lemillermicrosoft

Hey @poweihuang0817, there's a fix in my PR here to show INPUT variables when the value is not empty. https://github.com/microsoft/semantic-kernel/pull/1506

It's a one-line change in PlanStepCard to fix this, feel free to copy it over locally so you don't have to wait for the PR to merge image

teresaqhoang avatar Jun 15 '23 22:06 teresaqhoang

Fix merged here https://github.com/microsoft/semantic-kernel/pull/1555

teresaqhoang avatar Jun 19 '23 21:06 teresaqhoang