semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

python: add chroma memory store

Open joowon-dm-snu opened this issue 2 years ago • 5 comments

Motivation and Context

reopen #449

Description

Contribution Checklist

  • [ ] The code builds clean without any errors or warnings
  • [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [ ] All unit tests pass, and I have added new tests where possible
  • [ ] I didn't break anyone :smile:

joowon-dm-snu avatar May 11 '23 19:05 joowon-dm-snu

its draft, i'll add tests and update poetry soon

joowon-dm-snu avatar May 11 '23 19:05 joowon-dm-snu

Thanks for reopening this! Excited to get this in soon!

alexchaomander avatar May 11 '23 20:05 alexchaomander

Consider updating FEATURE_MATRIX.md to include these changes in the Connectors and Skill Libraries section.

lemillermicrosoft avatar May 12 '23 22:05 lemillermicrosoft

@awharrison-28 i think its almost done

joowon-dm-snu avatar May 13 '23 16:05 joowon-dm-snu

@joowon-dm-snu I just pushed a small change to the unit test workflow to hopefully fix the build issue for MacOS + Python 3.11

awharrison-28 avatar May 15 '23 23:05 awharrison-28

@joowon-dm-snu finally got a solution that works!

awharrison-28 avatar May 17 '23 19:05 awharrison-28