semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python: Add web file download skill to align with C#

Open turkey1zh opened this issue 2 years ago • 0 comments

Motivation and Context

Some skills are missing on Python and are needed to make a Python version of KernelHttpServer for sample apps.

#851

Description

This PR added web file download skill and related tests.

The implementation in this PR is based on the C# version.

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

turkey1zh avatar May 11 '23 08:05 turkey1zh