semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

WeaviateMemoryStore connector

Open codebrain opened this issue 1 year ago • 2 comments

Motivation and Context

Description

This adds a WeaviateMemoryStore, which allows for memories to be stored in Weaviate.

I have some outstanding questions, please help!

  1. Weaviate has strict naming conventions around class names (i.e. collections). What are the conventions in SK for class names?
  2. What are the most appropriate log levels for the connector? Please can you verify these are as expected?
  3. I have a suite of integration tests that can run against a Weaviate instance. I have implemented these integration tests before, in another project. Any guidance on how these should run for this repo? Ultimately it requires Weaviate running in a docker container.

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

codebrain avatar Apr 29 '23 11:04 codebrain

@microsoft-github-policy-service agree

codebrain avatar Apr 29 '23 23:04 codebrain

I have rebased again. Would it be possible to merge this sooner, rather than later, if possible?

Thanks.

codebrain avatar May 16 '23 02:05 codebrain

I have rebased again. Would it be possible to merge this sooner, rather than later, if possible?

Thanks.

Thanks for your patience. Will do our best to get this in this week. I can't see the conflicts right now to know what's remaining.

lemillermicrosoft avatar May 18 '23 22:05 lemillermicrosoft

5th rebase (!)

codebrain avatar May 20 '23 11:05 codebrain

5th rebase (!)

@codebrain -- It might be worth re-creating the PR with the checkbox of Enable edits by maintainers so we can rebase/merge main as appropriate.

lemillermicrosoft avatar May 23 '23 15:05 lemillermicrosoft

Closing in favour of a new PR with "Enable edits from Maintainers" enabled.

codebrain avatar May 25 '23 12:05 codebrain