semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Update Recall to asynchonously access memories

Open WretchedDade opened this issue 2 years ago • 1 comments

I opened #671 about a bug that I noticed when working with the semantic kernel locally. I created a patched version of the TextMemorySkill locally and found a small change that allowed it to work as expected. This PR is for that change.

Description

Updated TextMemorySkill.Recall to asynchronously access memories. This means Recall becomes RecalAsync.

Contribution Checklist

  • [X] The code builds clean without any errors or warnings
  • [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [X] All unit tests pass, and I have added new tests where possible
  • [X] I didn't break anyone :smile:

WretchedDade avatar Apr 26 '23 16:04 WretchedDade

Can you also try to add an IntegrationTest that would fail without these changes?

Yea, I'll see what I can add!

WretchedDade avatar Apr 26 '23 17:04 WretchedDade

@lemillermicrosoft, I tried adding that integration test. However, I can't get it to fail for the code prior to my changes. I guess it's something specific about my set up? I'll close this for now as I look into it further.

WretchedDade avatar Apr 26 '23 18:04 WretchedDade