semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Add GenAI support to Connectors.Onnx

Open feiyun0112 opened this issue 1 year ago • 4 comments

@stephentoub invite me to Contribute https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI to Microsoft.SemanticKernel.Connectors.Onnx

https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/issues/4

feiyun0112 avatar Jun 04 '24 04:06 feiyun0112

Excellent, thanks! I'll take a look soon.

stephentoub avatar Jun 05 '24 03:06 stephentoub

@feiyun0112 Thanks for the contribution!

rogerbarreto avatar Jun 06 '24 16:06 rogerbarreto

@RogerBarreto, I suggest we not hold this waiting for the ONNX runtime library targeting netstandard2.0. You ok with that?

stephentoub avatar Jun 10 '24 20:06 stephentoub

@feiyun0112 Two things for this PR

  1. Can you add unit tests to cover the new functionality, our target is 80% code coveregae
  2. Can you run dotnet format and commit the resulting changes

markwallace-microsoft avatar Jun 19 '24 10:06 markwallace-microsoft

@RogerBarreto, what are the next steps for this one?

stephentoub avatar Jul 12 '24 14:07 stephentoub

@stephentoub @RogerBarreto This is definitely going to be an awesome addition. Thanks for considering it. Big thanks to you @feiyun0112 for this as well :)

arafattehsin avatar Jul 22 '24 13:07 arafattehsin