semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Dotnet notebooks not working out of the box

Open eamon-keane opened this issue 9 months ago • 2 comments

Describe the bug Getting started notebook does not work as is. DirectoryPath is incorrect for the plugins

To Reproduce Steps to reproduce the behavior: Run the notebooks in order

Expected behavior Notebooks load plugins correctly

Screenshots If applicable, add screenshots to help explain your problem.

Platform

  • OS: Windows
  • IDE:VS Code
  • Language: C#

Additional context Need to update the path to this:

var funPluginDirectoryPath = Path.Combine(System.IO.Directory.GetCurrentDirectory(), "..", "..", "prompt_template_samples", "FunPlugin");

eamon-keane avatar May 14 '24 09:05 eamon-keane

I will submit a PR to fix when i get a chance

eamon-keane avatar May 14 '24 09:05 eamon-keane

Hello everyone,

I am not sure if this warrants a new issue, as it is closely related to the current one.

In the C# notebooks 02-running-prompts-from-file.ipynb, the references to the samples folder and the JokeFunction-function are not pointing to the correct paths.

I would be happy to make the necessary changes to fix both notebooks and submit a PR.

Alternatively, if you deem it necessary, I can create a new issue.

MichaelHomme avatar May 15 '24 19:05 MichaelHomme

@eamon-keane @MichaelHomme thanks for reporting this issue. I fixed path issues and also updated version of SK in notebooks to 1.11.1 in this PR: https://github.com/microsoft/semantic-kernel/pull/6273

dmytrostruk avatar May 15 '24 20:05 dmytrostruk

Excellent 👌

eamon-keane avatar May 15 '24 20:05 eamon-keane

Great, thanks 👍

MichaelHomme avatar May 15 '24 21:05 MichaelHomme