semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python: Adds a memory connector for Azure Cosmos DB for NoSQL

Open aayush3011 opened this issue 1 year ago • 2 comments

Motivation and Context

Azure Cosmos DB is adding Vector Similarity APIs to the NoSQL project, and would like Semantic Kernel users to be able to leverage them.

This adds a Memory Connector implementation for Azure Cosmos DB's, including support for the new vector search functionality coming soon in Cosmos DB.

Description

Contribution Checklist

aayush3011 avatar May 11 '24 23:05 aayush3011

Need to update the pyproject.toml and poetry.lock file once the new version is released for azure-cosmos

aayush3011 avatar May 11 '24 23:05 aayush3011

@moonbox3 , can you please review this PR as priority, we need this to be merged by this Friday for the Build Conference.

The python SDK will be released today EOD, and I will update the azure-cosmos dependency accordingly.

I have tested the functionality in my local, where it works correctly.

aayush3011 avatar May 15 '24 18:05 aayush3011

@moonbox3 , can you please review this PR as priority, we need this to be merged by this Friday for the Build Conference.

The python SDK will be released today EOD, and I will update the azure-cosmos dependency accordingly.

I have tested the functionality in my local, where it works correctly.

@aayush3011 Yes, I will review first thing in the morning. Tagging @eavanvalkenburg if he can look during his morning, too, which is before mine.

moonbox3 avatar May 16 '24 00:05 moonbox3

@aayush3011 you need to run poetry lock --no-update and I'll have a look at the code now

eavanvalkenburg avatar May 16 '24 04:05 eavanvalkenburg

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL6176103683% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1328 1 :zzz: 0 :x: 0 :fire: 12.043s :stopwatch:

markwallace-microsoft avatar May 16 '24 21:05 markwallace-microsoft

@moonbox3 @eavanvalkenburg Please review again, once you get a chance.

aayush3011 avatar May 16 '24 22:05 aayush3011

Unfortunately the new integration tests for this integration were not updated for the new function names, please have a look @aayush3011

eavanvalkenburg avatar May 17 '24 20:05 eavanvalkenburg