semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python Redis Memory Connector should allow for filtering when searching

Open engt21 opened this issue 1 year ago • 2 comments

As related to my investigations of the Python redis memory connector in https://github.com/microsoft/semantic-kernel/issues/6084 and https://github.com/microsoft/semantic-kernel/issues/6088, the redis memory connector by default only goes *=> to do the search. This will return all the keys in the store. However, there should be an option for the user to allow them to provide a key to filter on, much like in native redis. Although you can pass in the collection name, this allows for greater granularity and accuracy of RAG, especially for large applications that have similar values and many k-v pairs stored.

We found that when we had key value pairs with similar or nearly identical values, even when passing the collection name in, we got poor performance, unless we modified the filter.

engt21 avatar May 08 '24 14:05 engt21

@westey-m, adding you here so that you have context of some of the requests coming in for memory (in case it helps with creating the abstraction).

madsbolaris avatar May 10 '24 15:05 madsbolaris

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Aug 09 '24 01:08 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Aug 24 '24 01:08 github-actions[bot]