semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python Redis Memory Connector should be able to take existing redis connection, not just connection string

Open engt21 opened this issue 1 year ago • 2 comments

Python redis memory connector should be able to take an existing redis connection. For example, some enterprises require/have other methodologies to connect to redis beyond the default connection string and those connections require additional parameters that cannot work with the default connection string.

Since connecting via the connection string also returns a redis.Redis object and sets it to the memory connector's database attribute, passing in an existing redis connector to set to that attribute should also work.

Have already discussed this briefly with a member of the team.

I will provide the implementation/fix that worked in my enterprise in PR.

engt21 avatar May 01 '24 15:05 engt21

Please let me know if/when/what next steps are before I can raise a PR. Thanks!

engt21 avatar May 01 '24 19:05 engt21

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Aug 06 '24 01:08 github-actions[bot]

As of SK Python 1.5.0 the redis_store supports creating the object with an existing Redis database.

moonbox3 avatar Aug 14 '24 19:08 moonbox3