semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

add embeddings and HF secrets to syntax-examples readme

Open thegovind opened this issue 2 years ago • 2 comments

Motivation and Context

Running KernelSyntaxExamples tasks by following the readme will result in runtime errors due to missing secrets.

Description

Added missing secret keys to the readme so that Syntax Examples can be executed without exceptions, especially for:

  1. Example12_Planning and
  2. Example20_HuggingFace

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

thegovind avatar Apr 23 '23 19:04 thegovind

@thegovind Like branch is out of sync with main, We're unable to hit the "update" button, so we are blocked from merging. Please rebase. I recommend checking the "allow edits by maintainers" box so that the branch managers can update and merge -- otherwise, with so many changes, it'll likely repeated fall out of sync again.

shawncal avatar Apr 23 '23 22:04 shawncal

@thegovind Like branch is out of sync with main, We're unable to hit the "update" button, so we are blocked from merging. Please rebase. I recommend checking the "allow edits by maintainers" box so that the branch managers can update and merge -- otherwise, with so many changes, it'll likely repeated fall out of sync again.

@shawncal Don't see the option to allow edits anymore. I guess I should've done it at the time of PR submission. However, I did rebase. Could you try to merge again?

thegovind avatar Apr 26 '23 22:04 thegovind

Closing stale pr. We still cannot resolve these conflicts, so please feel free to re-open when the issues are resolved.

lemillermicrosoft avatar May 19 '23 18:05 lemillermicrosoft