semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Fix potential github action smells

Open ceddy4395 opened this issue 10 months ago • 2 comments

Motivation and Context

Description

Hey! 🙂 I want to contribute the following changes to your workflow:

  • Use commit hash instead of tags for action versions
  • Use fixed version for runs-on argument
  • Avoid jobs without timeouts
  • Prevent running issue/PR actions on forks
  • Steps should only perform a single command
  • Use names for run steps

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

Contribution Checklist

ceddy4395 avatar Apr 29 '24 18:04 ceddy4395

@microsoft-github-policy-service agree

ceddy4395 avatar Apr 29 '24 18:04 ceddy4395

@RogerBarreto Here is a scientific paper and a blog post about potential security risks related to GitHub Actions

ceddy4395 avatar May 01 '24 11:05 ceddy4395

Going to close this out because the team has decided that we'll remove both of these actions.

matthewbolanos avatar Jul 22 '24 15:07 matthewbolanos