semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Fix 5796 function calling enum params

Open Krzysztof318 opened this issue 1 year ago • 2 comments

Motivation and Context

Fixes https://github.com/microsoft/semantic-kernel/issues/5796

Description

Type for enum wasn't correctly set in JsonSchemaMapper, it didn't matter for OpenAI but gemini was throwing exception if type isn't specified. Fixed that with string type. Added new unit tests for Gemini and OpenAI. Both passed.

@RogerBarreto @SergeyMenshykh

DataHelper and BertOnyx was updated automatically by formatter.

Contribution Checklist

Krzysztof318 avatar Apr 24 '24 20:04 Krzysztof318

@Krzysztof318 could you take a look at the build error? Thanks.

markwallace-microsoft avatar May 09 '24 08:05 markwallace-microsoft

@markwallace-microsoft until 19.05 I am out of office

Krzysztof318 avatar May 09 '24 08:05 Krzysztof318