semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Update docs to remove references to SKFunction

Open jitendra-25 opened this issue 1 year ago • 6 comments

What is the difference between the [SKFunction] and [KernelFunction] attributes?

  1. On this document it is mentioned to use SKFunction attribute on ReadTextAsync method inside the DocumentPlugin - https://learn.microsoft.com/en-us/semantic-kernel/agents/plugins/?tabs=Csharp
  2. While on this document it is mentioned to use KernelFunction attribute on SendEmailAsync method inside the EmailPlugin - https://learn.microsoft.com/en-us/semantic-kernel/agents/

So, when should I use which attribute? Please clarify, also provide any documentation link if available.

Thanks, Jitendra

jitendra-25 avatar Jan 08 '24 14:01 jitendra-25

[SKFunction] was renamed to [KernelFunction]. Docs that still refer to "SKFunction" should be updated to "KernelFunction", as the former no longer exists.

stephentoub avatar Jan 08 '24 14:01 stephentoub

Changed the name of the issue to reflect the need to update the docs.

madsbolaris avatar Jan 08 '24 17:01 madsbolaris

Thanks for the clarification.

jitendra-25 avatar Jan 09 '24 07:01 jitendra-25

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Apr 09 '24 01:04 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Apr 26 '24 01:04 github-actions[bot]

Why is this issue closed as completed? The docs are still referencing SKFunction, example below:

https://learn.microsoft.com/en-us/semantic-kernel/agents/plugins/?tabs=Csharp

DanAIDev avatar May 11 '24 12:05 DanAIDev