semantic-kernel
semantic-kernel copied to clipboard
microsoft
Implement Planner Skill In Python
Feature Request:
Implement the planner skill. @alexchaomander said it wasn't being worked on internally, so I've started on it. Opening this as a tracker for semantic kernel planning skill implementation in the Python branch. I've been working on it and hoping to get a PR out soon, but wanted to make sure I was on the same page stylistically with the team.
Scope:
Current scope is planning skill feature parity with the main branch (although maybe a few commits behind)...
Thank you @renrut for picking this up!
I'd make sure to refer to the latest change in planner https://github.com/microsoft/semantic-kernel/discussions/170
Adding @jjhenkel and @vivekpandit-msft who can help review and keep you in sync on style.
Yes, thank you @renrut! Excited to see it --- there may be a good bit of churn here as we work on making the SK python-preview branch more "idiomatic python" (as the original code comes from a "direct from C# port" I did, so it's not very pythonic yet).
There's also a bunch of active work in the C# branch that has/will have implications for us here. (Things like an overhaul of the prompt template language and upgrades to the model backends to better support chat/images/etc.) Happy to do a review and help point out what might have changed/be changing when you have a PR out!
We'll actually be moving away from using a Skill for planning, so it might be worth some rethinking here or at least not doing too much work right away.
Okay. No worries, happy to hold off for now!
@jjhenkel - I was also scoping more of a direct port as well for planning since I was keen to get the python branch working with it.
@renrut totally can appreciate the idea to direct port, it worked decent enough for the rest of the repo! Thanks for being patient with us here as we work through both bringing things up to parity and moving the port towards something that looks more like reasonable Python code!
@renrut we have this PR in review now that introduces the Plan object model! https://github.com/microsoft/semantic-kernel/pull/255
Definitely follow along there
@renrut we have this PR in review now that introduces the Plan object model! #255
Definitely follow along there
Just the object model though, one step in a series of work that will end up removing the PlannerSkill.
quick update: the team is looking into this, we'll share updates in the following weeks.
