semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Python: Duplicate Configuration Code Block in 02-running-prompts-from-file.ipynb

Open gbm opened this issue 7 months ago • 3 comments

File: python/samples/getting_started/02-running-prompts-from-file.ipynb

Description: The following code block appears twice in the notebook and is only necessary once:

from services import Service

from samples.service_settings import ServiceSettings

service_settings = ServiceSettings()

# Select a service to use for this notebook (available services: OpenAI, AzureOpenAI, HuggingFace)
selectedService = (
    Service.AzureOpenAI
    if service_settings.global_llm_service is None
    else Service(service_settings.global_llm_service.lower())
)
print(f"Using service type: {selectedService}")

Suggestion: Please remove the duplicate (and also the supporting english sentence preceeding the repeated block) so that this code only appears once to avoid confusion and keep the notebook concise.

gbm avatar Jul 22 '25 11:07 gbm

It's a simple delete of the repeated code block in the notebook - I can open a PR or happy also for you to make this change yoursel(ves). :)

gbm avatar Jul 22 '25 11:07 gbm

Please feel free to make a PR, as well, @gbm. Thanks for the support.

moonbox3 avatar Jul 24 '25 06:07 moonbox3

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Oct 23 '25 02:10 github-actions[bot]