semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Fix functions_view.py

Open salmon131 opened this issue 2 years ago • 1 comments

Motivation and Context

#1212

Description

Fixed a bug in the process of checking native function.

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

salmon131 avatar May 25 '23 06:05 salmon131

Thanks for adding this! The team will review soon!

alexchaomander avatar May 26 '23 16:05 alexchaomander

closes https://github.com/microsoft/semantic-kernel/issues/1212

@salmon131 would you mind turning the examples you demonstrated in the above issue into unit tests?

awharrison-28 avatar Jun 02 '23 22:06 awharrison-28

@microsoft-github-policy-service agree company="ascentkorea"

salmon131 avatar Jun 03 '23 06:06 salmon131

@awharrison-28 I added a unit test for the example. Existing code fails when performing test_is_native(), but modified code passes the test.

salmon131 avatar Jun 03 '23 06:06 salmon131

to fix the linting issue, run poetry run black . under semantic-kernel/python

I tried to do it myself, but I hit an issue pushing to this PR.

awharrison-28 avatar Jun 05 '23 22:06 awharrison-28

@awharrison-28 I solved the lint issue. Please check.

salmon131 avatar Jun 07 '23 03:06 salmon131

@awharrison-28 I solved the lint issue. Please check.

Looks like you'll need to do poetry run ruff check . as well

awharrison-28 avatar Jun 07 '23 18:06 awharrison-28

@awharrison-28 I also performed a ruff check. Please check.

salmon131 avatar Jun 08 '23 01:06 salmon131