semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Remove dependency on xunit.analyzers

Open dluc opened this issue 1 year ago • 3 comments

Motivation and Context

SK package should not depend on analyzers. Looks like xunit.analyzers pkg is somehow differently and the XML needed wasn't added automatically like other analyzers.

Description

Edit Directory.Packages.props and remove xunit.analyzers dependency from the nuget. I also noticed a couple of duplicate files left over from a bad merge (a folder rename), the PR takes care of deleting them.

dluc avatar Mar 19 '23 22:03 dluc

Before:

image

After:

image

dluc avatar Mar 19 '23 22:03 dluc

@timlaverty recently we renamed the folder SemanticKernel.Test to SemanticKernel.UnitTests and due to how some PRs got merged, the files ended up being duplicated

dluc avatar Mar 20 '23 07:03 dluc

I removed obsolete unit-tests in previous PR as well: https://github.com/microsoft/semantic-kernel/pull/110

dmytrostruk avatar Mar 20 '23 09:03 dmytrostruk