semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

DuckDB as memory storage

Open colombod opened this issue 1 year ago • 1 comments

Motivation and Context

DuckDB is becoming a popular option for in memory OLAP storage. This pr contributes a MemoryStorage implementation on DuckDB using both tile and in memory setup.

Description

DuckDB memory storage implementation

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

colombod avatar May 18 '23 20:05 colombod

Addressed comments

colombod avatar May 20 '23 19:05 colombod

Looks great overall! Haven't tested yet. Left a few comments for now.

I think I have addressed the comments

colombod avatar May 27 '23 23:05 colombod