sarif-web-component icon indicating copy to clipboard operation
sarif-web-component copied to clipboard

Add filtering based on Rule, Tag, and Result Kind

Open gfs opened this issue 3 years ago • 2 comments

For triaging, especially a large sarif, it is helpful to be able to filter based on attributes of the results.

gfs avatar Feb 16 '22 00:02 gfs

Filtering based on Rule is supported via the text field. We do not have a dedicated dropdown for Rule.

Filtering for Tag is not currently supported. It can be added by way of the text field. If we add a dedicated dropdown, there might be a load-time perf consideration was we would need to gather all possible tags first.

Filtering for Kind is not currently supported. We can potentially add a dropdown for it.

Filtering based on Level is supported. The dropdown is visible unless configured otherwise.

jeffersonking avatar Feb 22 '22 09:02 jeffersonking

Filtering based on Rule is supported via the text field. We do not have a dedicated dropdown for Rule.

Is it documented somewhere what "keyword" means in the context of the search bar? Could I search for two rules? is it regex? What fields is it searching against?

Filtering for Tag is not currently supported. It can be added by way of the text field. If we add a dedicated dropdown, there might be a load-time perf consideration was we would need to gather all possible tags first.

I understand that there might be a perf hit from gathering all the tags - but excluding that this misses the case that the user who is loading the sarif may not know what tags are in it and may want to browse through all the associated tags.

Filtering for Kind is not currently supported. We can potentially add a dropdown for it.

That would be great.

gfs avatar Feb 22 '22 18:02 gfs