rushstack icon indicating copy to clipboard operation
rushstack copied to clipboard

[rush] Can update-autoinstallers write common/autoinstallers/rush-plugins/.rush/temp/last-install.flag?

Open LPegasus opened this issue 1 month ago • 2 comments

Summary

After executing rush update-autoinstaller, the .rush/temp/last-install.flag file was not written, causing subsequent related commands to perform the installation again.

Repro steps

  • Change any dependencies version in autoinstallers/*/package.json
  • Run rush update-autoinstaller --name xxx.
  • Run rush install-autoinstaller --name xxx. Expect to skip installation.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.155.1
rushVersion from rush.json? 5.155.1
useWorkspaces from rush.json? Yes
Operating system? Mac
Would you consider contributing a PR? Yes
Node.js version (node -v)? 22.20.0

LPegasus avatar Nov 25 '25 07:11 LPegasus

Do I understand correctly that we just need to refer to the code logic in https://github.com/microsoft/rushstack/blob/1627a8386debc01fe198a2efcac0b8fa09fa5384/libraries/rush-lib/src/logic/Autoinstaller.ts#L106-L170 and implement the same generation logic for the last-install.flag file in https://github.com/microsoft/rushstack/blob/1627a8386debc01fe198a2efcac0b8fa09fa5384/libraries/rush-lib/src/logic/Autoinstaller.ts#L173?

LPegasus avatar Nov 25 '25 07:11 LPegasus

Looks like a simple oversight. @LPegasus, that seems like the right place.

iclanton avatar Dec 03 '25 19:12 iclanton