rushstack icon indicating copy to clipboard operation
rushstack copied to clipboard

[eslint-patch] The bulk suppressions feature should report bulk suppressed problems as "suppressed"

Open dmichon-msft opened this issue 11 months ago • 0 comments
trafficstars

Summary

The linter outputs messages and suppressedMessages. Currently issues suppressed by eslint-bulk-suppressions show up in neither. Issues suppressed by //eslint-disable* directives show up in suppressedMessages. This is relevant because when generating audit reports, the set of suppressedMessages are relevant.

Repro steps

Inspect the suppressedMessages field of the linter results via debugger in a project with eslint-bulk-suppressions configured and suppressing problems.

Expected result: The lint problems being suppressed by eslint-bulk-suppressions should be present in suppressedMessages, with some explanation indicating that they were suppressed by the eslint-bulk-suppressions feature.

Actual result: The lint problems being suppressed by eslint-bulk-suppressions are not visible at all.

Details

This is a consequence of the eslint-bulk-suppressions feature omitting problems from the output entirely, instead of setting the problem.suppression field.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
Package name: @rushstack/eslint-patch
Package version? 1.10.4
Operating system? Linux
Would you consider contributing a PR? Yes
Node.js version (node -v)? 18.19.1

dmichon-msft avatar Dec 18 '24 22:12 dmichon-msft