reverse-proxy icon indicating copy to clipboard operation
reverse-proxy copied to clipboard

Documentation Maintenance For Kubernetes Controller

Open nquandt opened this issue 2 years ago • 4 comments

What should we add or change to make your life better?

I noticed an update to the Kubernetes.Controller by @witskeeper, I realize now that "reviewing" a completed PR will probably not be noticed, so I am submitting this issue as reference. #1913

Why is this important to you?

Required configurations should be mentioned / documented somewhere when changed.

image

nquandt avatar Jan 30 '23 23:01 nquandt

I agree, at a minimum, it would be worth commenting on the YarpOptions when things are deemed required and updating examples to match. If there are any required settings, we should also validate that and fail early.

Even if updating the status failed, we likely shouldn't prevent the reconciler loop from continuing.

MihaZupan avatar Feb 02 '23 15:02 MihaZupan

Also need get on ingresses/status. Samples don't have it.

specialforest avatar May 17 '23 01:05 specialforest

Could you please update the title to make the bug searchable?

Nevertheless, reposting error stack trace:

warn: Yarp.Kubernetes.Controller.Services.Reconciler[0]
      Uncaught exception occured while reconciling
      System.ArgumentNullException: Value cannot be null. (Parameter 'name')
         at k8s.AbstractKubernetes.k8s.ICoreV1Operations.ReadNamespacedServiceStatusWithHttpMessagesAsync(String name, String namespaceParameter, Nullable`1 pretty, IReadOnlyDictionary`2 customHeaders, CancellationToken cancellationToken)
         at k8s.CoreV1OperationsExtensions.ReadNamespacedServiceStatusAsync(ICoreV1Operations operations, String name, String namespaceParameter, Nullable`1 pretty, CancellationToken cancellationToken)
         at Yarp.Kubernetes.Controller.Client.V1IngressResourceStatusUpdater.UpdateStatusAsync()
         at Yarp.Kubernetes.Controller.Services.Reconciler.ProcessAsync(CancellationToken cancellationToken) in src\Kubernetes.Controller\Services\Reconciler.cs:line 71

and keywords ControllerServiceName ControllerServiceNamespace.

specialforest avatar May 17 '23 01:05 specialforest

Also it updates the status of all ingresses in the cluster without IsYarpIngress check :(

specialforest avatar May 17 '23 16:05 specialforest