retina icon indicating copy to clipboard operation
retina copied to clipboard

fix: Set PowerShell path using environment variables

Open xiaozhiche320 opened this issue 1 year ago • 2 comments

Description

Kusto complain the system cannot find the powershell path in Windows, I noticed in windows we are currently hardcoding the powershell path in hpc folder, since the windows powershell in PATH environment variable lost issue was fixed, we should change it back instead of hard code the path

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • [ ] I have read the contributing documentation.
  • [ ] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [ ] I have correctly attributed the author(s) of the code.
  • [ ] I have tested the changes locally.
  • [ ] I have followed the project's style guidelines.
  • [ ] I have updated the documentation, if necessary.
  • [ ] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

xiaozhiche320 avatar Oct 11 '24 14:10 xiaozhiche320

Hi @xiaozhiche320, thanks for raising this PR. Can you attach screenshots of before vs. after?

huntergregory avatar Oct 11 '24 18:10 huntergregory

Hi @xiaozhiche320, thanks for raising this PR. Can you attach screenshots of before vs. after?

Hi Hunter, the screen are listed as below: I add some context when testing if retina-win image work correctly, the work directory and the powershell env variable exist in both win-2019 and win-2022 Azure Container and it failed here for windows 2019 before After (just set the time stamp from 10 min to 1 min and check if the call worked correctly) image

xiaozhiche320 avatar Oct 11 '24 19:10 xiaozhiche320