microsoft
edge cases for MetricConfiguration CRD
If enableAnnotations=false, then advanced metrics won't show up unless a MetricConfiguration CRD exists (metric modules are initialized via metricModule's Reconcile()). We should initialize with default context options instead.
Also, should we support MetricConfiguration CRD when enableAnnotations=true? Right now, we do not:
https://github.com/microsoft/retina/blob/9248f0d140e5c93da77bdbdf5e43ea3b0029cfd4/controller/main.go#L254-L268
Also, should we support MetricConfiguration CRD when enableAnnotations=true? Right now, we do not:
As a user, it took me a long time to figure out why MetricConfiguration CR seemed to make no effect. 😃 Turned out it was indeed because I had enableAnnotations=true, which to me was not intuitive.
Hi @vakalapa! I have been using Retina for a couple of weeks now and I would like to work on this issue. So the goal is to initialize metricsConfigController even if MetricConfiguration CR doesn't exist. In that case, we need to initialize the controller with default config right? Correct me If I am wrong.
https://github.com/microsoft/retina/blob/9248f0d140e5c93da77bdbdf5e43ea3b0029cfd4/controller/main.go#L221
Also if you provide more info it'll be helpful to move forward.
Hi @vakalapa! I have been using Retina for a couple of weeks now and I would like to work on this issue. So the goal is to initialize
metricsConfigControllereven if MetricConfiguration CR doesn't exist. In that case, we need to initialize the controller with defaultconfigright? Correct me If I am wrong.Line 221 in 9248f0d
metricsModule := mm.InitModule(ctx, config, pubSub, enrich, fm, controllerCache) Also if you provide more info it'll be helpful to move forward.
@roopeshsn this is correct 🙂
Would that gather metrics for all resources in the cluster? We are currently missing that feature (without having to define a MetricConfiguration CR)
