retina icon indicating copy to clipboard operation
retina copied to clipboard

tool(dev): update dev container, makefile, remove object files

Open snguyen64 opened this issue 1 year ago • 3 comments

Description

Updates to the dev container to use kind and kind registry for local testing. Removes generated files including mocks Update mock generates to be consistent Update linting to 1.60.3 for workflow and local lint and update deprecated linters.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • [ ] I have read the contributing documentation.
  • [ ] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [ ] I have correctly attributed the author(s) of the code.
  • [ ] I have tested the changes locally.
  • [ ] I have followed the project's style guidelines.
  • [ ] I have updated the documentation, if necessary.
  • [ ] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

snguyen64 avatar Aug 15 '24 21:08 snguyen64

hmm pretty sure we needed those empty object files, so the linter doesn't complain 🤔

nddq avatar Aug 15 '24 21:08 nddq

@snguyen64 i just remember one thing, we might need those. o files for vendoring as well since they are embedded in the generated ebpf wrapper files. go mod vendor will not success IIRC, but you can verify it

nddq avatar Sep 04 '24 21:09 nddq

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar Oct 05 '24 00:10 github-actions[bot]

Pull request closed due to inactivity.

github-actions[bot] avatar Oct 13 '24 00:10 github-actions[bot]