retina icon indicating copy to clipboard operation
retina copied to clipboard

feat: Add s3 upload output for capture

Open parkjeongryul opened this issue 1 year ago • 1 comments

Description

This PR implement outputConfiguration.s3Upload feature.

Related Issue

#201

Checklist

  • [x] I have read the contributing documentation.
  • [x] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [x] I have correctly attributed the author(s) of the code.
  • [x] I have tested the changes locally.
  • [x] I have followed the project's style guidelines.
  • [x] I have updated the documentation, if necessary.
  • [x] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

I've tested it working well in the two environments below.

AWS s3

./bin/kubectl-retina  capture create --s3-region ap-northeast-2 --s3-bucket retina-test-bucket --s3-access-key-id my-access-key --s3-secret-access-key my-secret-key  --node-selectors "kubernetes.io/os=linux"  --debug
image

minio

./bin/kubectl-retina  capture create --s3-endpoint https://play.min.io:9000  --s3-bucket test-jrpark-bucket --s3-access-key-id Q3AM3UQ867SPQQA43P2F --s3-secret-access-key zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG --node-selectors "kubernetes.io/os=linux"  --debug
image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

parkjeongryul avatar Apr 18 '24 20:04 parkjeongryul

@microsoft-github-policy-service agree

parkjeongryul avatar Apr 18 '24 20:04 parkjeongryul

I will address the CI lint issues shortly and update the PR accordingly. Please hold off on further review until updated. Thanks!

parkjeongryul avatar Apr 22 '24 09:04 parkjeongryul

@parkjeongryul Looks good to me. Thanks for the contribution. I'll approve it once the build is succeeding.

spencermckee avatar Apr 23 '24 00:04 spencermckee

@spencermckee I think that the CI lint issues have been resolved.

parkjeongryul avatar Apr 23 '24 15:04 parkjeongryul